Correct Schema::check_compatible to resolve types in a ModuleDef
#1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue for me! I don't really understand the context around this code but seems like an improvement. |
cloutiertyler
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When performing an automatic migration, we check the old moduledef is compatible with the data stored in the system tables.
But right now, the types stored in the system tables are resolved, but the types in the moduledef are not. So the check breaks on nested types. This PR fixes that and adds a regression test for it.
I'd like to do a followup PR adding more intensive automigration testing.
Expected complexity level and risk
0
Testing
Added a failing test, fixed the test.